• src/sbbs3/smbutil.c

    From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Wed May 6 22:36:56 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/1fbe29cb3c13f8878731477d
    Modified Files:
    src/sbbs3/smbutil.c
    Log Message:
    smbutil: free idxbuf and unlock smbhdr on terminated abort in maint() (CID 644892)

    Five 'if (terminated) return;' sites in maint() leaked idxbuf (heap)
    and left the SMB header lock held. The deletion-execution loop also
    left the SMB-allocation file handles open. Mirror the existing
    "nothing to delete" cleanup before each early return.

    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Wed May 6 22:36:57 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/7506c7bf8670aeacf982f282
    Modified Files:
    src/sbbs3/smbutil.c
    Log Message:
    smbutil: free datoffset on fread early-return in packmsgs() (CID 462184)

    Three bare 'return;' statements after the smb-header-rewrite reads
    leaked datoffset (allocated just above for the per-msg offset map).
    Free it before returning. Other resources at these sites (tmp file
    handles, smb header lock) are pre-existing leaks that Coverity did
    not flag and are out of scope for this CID.

    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)