https://gitlab.synchro.net/main/sbbs/-/commit/69e23e724e4e9dd2cd905b7d
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Move the backup of dsts.ini before opening the file

Can't backup (make copies of) an open file.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3b602ca5349f2b4143ff27ab
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Check return value of getnodedat()

Should fix CID 515599 since this seems to be the only place we call unlocknodedat() without possibly not owning the nodefile_mutex already.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b6b3e89091f941ab6ba3ea01
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Actually use the (first) shell we found that the user meets the requirements

As discovered and reported by Deuce and Nelgin

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/437b1a13e91a9878480671d7
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Don't backup dsts.ini daily

Looks like an unintentional debug-inclusion with commit 2064f3a4f71c6656693a1 as pointed about by Deuce in IRC.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9eaeedc13950d1ec26af5963
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Do rollover daily stats (dsts.ini) if the previous date was Jan-1-1970 (never)

Basically revert commit 2064f3a4f71c6656693a1d24fc63004c3c41aaea

In a new install, the "Date" value in dsts.ini will be 0/Never and thus would never be rolled over (e.g. stats moved o csts.tab files).

Since getstats() now reliably detects any read failures, we shouldn't need
this as a work-around any more anyway - if the "date" field is 0, it just
means a new install and it's expected.

This should fix the issue reported by Basis where the ctrl/csts.tab and node*/csts.tab files were never created in fresh install of v3.20. A work around is to just set the Date field in the ctrl/dsts.ini file to the current date (one time).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ae706b8054af1f291bfcd9ca
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Don't turn off the "ASCII only" user setting during logon

... when auto-terminal-type detection is enabled for the user

Fix for issue #923

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/53c42100db8385eb3a965888
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Better error reporting in logonstats()

Eastside75 (THUNDER) is reporting that their daily statistics (ctrl/dsts.ini) file is never "rolled-over" and there are only a couple of potential errors
in this function that could "silently fail" if the current date/time or the "Date" value in the dsts.ini file could not be converted to a broken-down date/time. So if either of those errors happen, log an error. It's unknown
what the cause of Eastside75's issue is, but I wanted to at least eliminate these 2 possible errors (failures in calls to localtime_r()) as potential causes.

Also, cleaned up a little using new dates_are_same() function, etc.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a51dd4dc5d08d22fee21c3c0
Modified Files:
src/sbbs3/logon.cpp
Log Message:
A blank ReadYourMailNowQ text.dat string will not defeat the Unread mail prompt

I sbbs_t::noyes() will return true if this string is blank, so we didn't need check here now anyway.

Setting ReadYourMailNowQ in text.dat to an empty string means this prompt
won't be shown and the read messages will *not* be shown during logon.

Setting ReadYourUnreadMailNowQ in text.dat to an empty string means this
prompt won't be shown and any unread messages *will* be shown during logon (automatically).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/377454c2db49f071cf24188c
Modified Files:
src/sbbs3/logon.cpp
Log Message:
When displaying unread mail during logon, use user-preferred sort order

Update to fix for feature request #1027

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net