• src/sbbs3/download.cpp sb

    From Rob Swindell (on Windows@VERT to Git commit to main/sbbs/m on Tue Nov 19 13:36:00 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/51c917d043aa2d0d85fed78d
    Modified Files:
    src/sbbs3/download.cpp sbbs.h telgate.cpp xtrn.cpp
    Log Message:
    Allow Telnet client to be in binary mode persistently

    Before this change, we'd always request a return to Telnet NVT (turn off binary-TX in both directions) after any file transfer. So although a Telnet session might be negotiated into binary mode shortly after connection
    (e.g., using "telnet -8"), it would be reverted back to NVT mode after any
    file transfer.

    The request to turn off remote binary-TX after executing external programs didn't actually accomplish anything since we track the Telnet option states internally and don't send redundant requests (e.g. the change into a mode
    we're already in). External programs aren't expected to send Telnet requests anyway, so I think this was some holdover from early days of stp/sexyz development.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS@VERT to Git commit to main/sbbs/m on Tue Nov 19 22:55:00 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/68c39a082dfc544dcd52d40b
    Modified Files:
    src/sbbs3/download.cpp sbbs.h
    Log Message:
    Save and restore the Telnet BINARY_TX option state separate for each direction

    It's possible the client requested binary transmit in only one of the two directions and if so, restore just the direction that was previously *not*
    in binary transmit mode to NVT mode.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net